Skip to content

Commit 4ba4afd

Browse files
authored
Merge pull request #2779 from internetarchive/hotfix/bwb-urllib2
hotfixing urllib2 + bwb API
2 parents 16c3e6c + d15e47f commit 4ba4afd

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

openlibrary/core/vendors.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import web
33
import urllib2
44
import simplejson
5+
import requests
56
from amazon.api import SearchException
67
from infogami import config
78
from infogami.utils.view import public
@@ -13,7 +14,7 @@
1314
from openlibrary import accounts
1415

1516

16-
BETTERWORLDBOOKS_API_URL = 'http://products.betterworldbooks.com/service.aspx?ItemId='
17+
BETTERWORLDBOOKS_API_URL = 'https://products.betterworldbooks.com/service.aspx?ItemId='
1718
AMAZON_FULL_DATE_RE = re.compile('\d{4}-\d\d-\d\d')
1819
ISBD_UNIT_PUNCT = ' : ' # ISBD cataloging title-unit separator punctuation
1920

@@ -291,10 +292,8 @@ def _get_betterworldbooks_metadata(isbn):
291292

292293
url = BETTERWORLDBOOKS_API_URL + isbn
293294
try:
294-
req = urllib2.Request(url)
295-
f = urllib2.urlopen(req)
296-
response = f.read()
297-
f.close()
295+
r = requests.get(url)
296+
response = r.content
298297
product_url = re.findall("<DetailURLPage>\$(.+)</DetailURLPage>", response)
299298
new_qty = re.findall("<TotalNew>([0-9]+)</TotalNew>", response)
300299
new_price = re.findall("<LowestNewPrice>\$([0-9.]+)</LowestNewPrice>", response)

0 commit comments

Comments
 (0)