Preserve credentials after retryable token refresh failures - #645
Merged
larryrider merged 2 commits intoJul 28, 2026
Conversation
larryrider
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes token refresh failure handling so stored credentials are only cleared when the refresh failure indicates invalid or expired credentials.
Retryable failures such as
5xx,408,429, or network/unknown errors now preserve the existing credentials and return the error to the caller. This avoids leaving long-running WebDAV sessions permanently logged out after a transient API failure.Why
A transient
503during token refresh can currently clear the saved user credentials. After that, all following WebDAV requests fail withMissing credentials, please login firstuntil the container is manually re-authenticated or restarted.Behavior
401/403.503,408,429, or missing HTTP status.Tests
401clearing credentials.503preserving credentials.