Feat/add dolphin file system extension by egalvis27 · Pull Request #412 · internxt/drive-desktop-linux

egalvis27 · 2026-07-22T01:40:12Z

Summary

This PR adds Dolphin file manager integration to Internxt Drive on Linux.

What Changed

Added a Dolphin service menu entry to expose a new Copy Internxt Link action.
Added the Dolphin helper script that:
- resolves the selected file path
- calls the local hydration API
- copies the generated Internxt link to the clipboard
Extended the file manager extension installer to detect Dolphin and install the required assets in the correct KDE locations.
Added logic to reload Dolphin after installing or updating the extension.
Bumped the file manager extension version so existing installations get the new Dolphin assets.
Added and updated tests for the file manager extension install and service behavior.

Notes

The Dolphin integration is packaged alongside the app.
KDE-specific behavior was adjusted so the menu entry shows correctly and the action runs without permission errors.

Validation

Focused Vitest coverage for the file manager extension passes.
Packaging succeeds with npm run package.

coderabbitai · 2026-07-22T01:40:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 459bcce6-98df-4981-9a11-c4a912884c36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/add-dolphin-file-system-extension

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

egalvis27 · 2026-07-29T20:32:31Z

+      const destinationExists = await doesFileExist(destination);
+      if (destinationExists) {
+        if (asset.executable) {
+          await fs.chmod(destination, 0o755);


The permissions granted to this script are strictly those necessary for the extension's features to function properly without compromising the security of the user's device.

but why does it need to be readable and executable by the group and all other users? These are the kind of details that I would like you to explain the why behind the decission

The 0o755 permission level poses no security risk and is precisely what is required here.

In Linux octal notation, 0o755 breaks down as:

Owner (7 -> rwx): Full read, write, and execute permissions. Only the file owner can modify it.

Group (5 -> r-x): Read and execute permissions.

Others (5 -> r-x): Read and execute permissions.

We grant read/execute access to group and other users because the file manager—as well as other GUI background processes—needs to invoke and read this extension across different contexts. Restricting these permissions will prevent the extension from loading or rendering in context menus.

Security impact is minimal since write permissions are strictly withheld from non-owner users; no third party can edit, overwrite, or swap the file. Additionally, the file handles no sensitive data and solely serves as an entry point for the file manager to run the integration upon invocation.


-  await fs.cp(source, destination);
+      if (asset.executable) {
+        await fs.chmod(destination, 0o755);


egalvis27 · 2026-07-29T20:23:27Z

+X-KDE-ServiceTypes=KonqPopupMenu/Plugin
+Actions=InternxtCopyLink;
+X-KDE-Submenu=Internxt Drive
+X-KDE-Priority=TopLevel


For Dolphin, new options must be configured using a new .desktop file that directly modifies the system settings.

egalvis27 · 2026-07-29T20:28:38Z

+    print("")
+    sys.exit(0)
+
+relative_path = file_path[len(root_folder):]


The functionality to generate the share link is still present in the app's code and can be accessed through the hydration API. This made it easy for us to create this script, which calls the corresponding endpoint and saves the link to the clipboard.

Since the extension's settings are managed directly through the system settings, it was necessary for the actions to be executed through this script.

egalvis27 · 2026-07-29T20:35:07Z

    },
    "deb": {
-      "depends": [
+      "recommends": [


The installation of this add-on has been changed to “recommended” because in distributions such as Kubuntu that use KDE, this library is not available by default and prevents the application from being installed.

…hin-file-system-extension

…or file system extension (#421)

…extension

AlexisMora · 2026-07-31T15:02:21Z

+        fileManager: [nautilus, nemo, dolphin]
+
+    container:
+      image: ubuntu:24.04


we could use either the newest lts or the oldest active, what do you think? (22.04)

AlexisMora · 2026-07-31T16:49:57Z

 const execAsync = promisify(exec);

-export type FileManagerType = 'nautilus' | 'nemo' | null;
+export type FileManagerType = 'nautilus' | 'nemo' | 'dolphin' | null;


isnt SupportedFileManager basically this?

Yes, I replaced it

AlexisMora · 2026-07-31T16:57:15Z

+  { type: 'nautilus', desktopEntry: 'nautilus.desktop', hasBinary: hasNautilusBinary },
+];

 export async function detectAvailableFileManager(): Promise<FileManagerType> {


You are making FileManagerType to have null just because this function is returning null and then
type FileManagerCandidate = { type: Exclude<FileManagerType, null>;
Why not rather make this function return FileManagerType | null?

AlexisMora · 2026-07-31T17:02:43Z

+export async function isDolphinAvailable(): Promise<boolean> {
+  return (await detectAvailableFileManager()) === 'dolphin';
+}
+


What is this used for? I see it has no usage

I had added them to generate alerts like the one generated by Nautilus, but now that I think about it, the alert should say that there is no extension available.

AlexisMora · 2026-07-31T17:04:18Z

+  return (await detectAvailableFileManager()) === 'dolphin';
+}
+
 async function getDefaultDirectoryDesktopEntry(): Promise<string> {


why not make this method directly pass the type of desktop rather than a string??

The feature has been removed

AlexisMora · 2026-07-31T17:13:45Z

+const nautilusExtensionFileName = 'internxt-virtual-drive.py';
+const nemoExtensionFileName = 'internxt-virtual-drive.py';
+const dolphinMenuFileName = 'internxt-virtual-drive.desktop';
+const dolphinHelperFileName = 'internxt-dolphin-actions.sh';


This should be ina consttants files

AlexisMora · 2026-07-31T17:13:47Z

+      if (destinationExists) {
+        if (asset.executable) {
+          await fs.chmod(destination, 0o755);
+        }


Check the sonar issues because both sonar and gh are screaming

The permissions granted to this script are strictly those necessary for the extension's features to function properly without compromising the security of the user's device.

I have already read your reply to the gh issue, there is no need to copy paste it 🙂

AlexisMora · 2026-07-31T17:13:47Z

-  await fs.cp(source, destination);
+      if (asset.executable) {
+        await fs.chmod(destination, 0o755);
+      }


Same for this

Review last comment

…e file handling

…d clarity and functionality

AlexisMora · 2026-08-03T07:18:41Z

    if (!fileManager) {
      logger.debug({
-        msg: '[FILE_MANAGER_EXTENSION] No compatible file manager found (Nautilus or Nemo)',
+        msg: '[FILE_MANAGER_EXTENSION] No compatible file manager found (Nautilus, Nemo or Dolphin)',


Question: Shouldnt we use a banner to tell the user this info? and perhaps an issue? or even a native notification, this way the user exactly knows what is happening when the error occurs

AlexisMora · 2026-08-03T07:20:31Z

+      type: 'dolphin',
+      reloadCommand: 'kquitapp6 dolphin || kquitapp5 dolphin || true',
+      assets: [
+        {
+          source: 'dolphin/internxt-virtual-drive.desktop',
+          destination: `${homedir}/.local/share/kio/servicemenus/${DOLPHIN_MENU_FILENAME}`,
+          template: true,
+          executable: true,
+        },
+        {
+          source: 'dolphin/internxt-virtual-drive.desktop',
+          destination: `${homedir}/.local/share/kservices5/ServiceMenus/${DOLPHIN_MENU_FILENAME}`,
+          template: true,
+          executable: true,
+        },
+        {
+          source: `dolphin/${DOLPHIN_HELPER_FILENAME}`,
+          destination: `${homedir}/.local/share/internxt-dolphin-extension/${DOLPHIN_HELPER_FILENAME}`,
+          executable: true,
+        },
+      ],


perhaps this kind of information could go into the paths file no? what do you think?

AlexisMora · 2026-08-03T07:20:53Z

+function getExtensionFile(source: string): string {
  if (process.env.NODE_ENV === 'development') {
-    return path.join(__dirname, `../../../../assets/${assetDir}`, extensionFileName);
+    return path.join(__dirname, `../../../../assets/${source}`);
  } else {
-    return path.join(process.resourcesPath, 'assets', assetDir, extensionFileName);
+    return path.join(process.resourcesPath, 'assets', source);
  }


… update service logic

… extension

+  }
+
+  if (name === 'temp') {
+    return process.env.TMPDIR || '/tmp';


…cation

sonarqubecloud · 2026-08-03T14:17:43Z

Quality Gate failed

Failed conditions
52.6% Coverage on New Code (required ≥ 80%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

egalvis27 added 2 commits July 21, 2026 12:27

feat: Add Dolphin file manager support and extension assets

6d2babd

feat: Update Dolphin extension and tests for improved functionality

30f0731

github-advanced-security AI found potential problems Jul 22, 2026

View reviewed changes

feat: Refactor file manager detection logic for improved maintainability

b357477

egalvis27 commented Jul 29, 2026

View reviewed changes

Comment thread src/backend/features/file-manager-extension/version.ts Outdated

egalvis27 commented Jul 29, 2026

View reviewed changes

egalvis27 added 3 commits July 30, 2026 10:18

Merge branch 'feat/add-nemo-file-system-extension' into feat/add-dolp…

19523b2

…hin-file-system-extension

feat: Add documentation for prerequisites and implement smoke tests f…

2aea788

…or file system extension (#421)

fix: Remove unnecessary blank line in service tests for file manager …

63326dc

…extension

AlexisMora reviewed Jul 31, 2026

View reviewed changes

egalvis27 added 2 commits July 31, 2026 16:43

feat: Update file manager extension to support null values and improv…

8905df4

…e file handling

feat: Refactor file manager extension constants and tests for improve…

84a2cdd

…d clarity and functionality

AlexisMora reviewed Aug 3, 2026

View reviewed changes

AlexisMora requested changes Aug 3, 2026

View reviewed changes

egalvis27 added 2 commits August 3, 2026 08:08

feat: Integrate PATHS constants for Dolphin file system extension and…

1b17de5

… update service logic

feat: Update smoke test script and add electron mock for file manager…

836ee7b

… extension

github-advanced-security AI found potential problems Aug 3, 2026

View reviewed changes

Comment thread src/backend/features/file-manager-extension/smoke-electron-mock.cjs Outdated

}

if (name === 'temp') {

return process.env.TMPDIR || '/tmp';

feat: Update smoke test script to reference new electron mock file lo…

3f0032a

…cation

AlexisMora approved these changes Aug 3, 2026

View reviewed changes

egalvis27 merged commit be7f20e into feat/add-nemo-file-system-extension Aug 3, 2026
14 of 15 checks passed

egalvis27 deleted the feat/add-dolphin-file-system-extension branch August 3, 2026 19:51

Uh oh!

Conversation

egalvis27 commented Jul 22, 2026

Summary

What Changed

Notes

Validation

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Aug 3, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading