[PB-6707]: surface failed uploads in the retry modal and task logger - #2076
Conversation
Retry entries are grouped under their parent folder task via relatedTaskId, and non-retryable files show a "Not allowed" label (added to all locales) instead of a retry button. Also normalizes the two RetryableTask param shapes in TaskToRetryItem behind a getDisplayData helper (file names now display with their extension), tightens the retry modal row padding, and adds sizeClassName/iconSize props to TaskLoggerButton.
Deploying drive-web with
|
| Latest commit: |
ed1ed09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a15de695.drive-web.pages.dev |
| Branch Preview URL: | https://feat-failed-uploads-retry-ui.drive-web.pages.dev |
| return haveWarnings ? ( | ||
| <TaskLoggerButton onClick={infoAction} Icon={InfoIcon} iconSize={20} /> | ||
| ) : ( | ||
| <TaskLoggerButton onClick={magnifyingAction} Icon={MagnifyingGlass} /> |
There was a problem hiding this comment.
If there’s any file with error, do we no longer display the magnifying glass icon to navigate to the folder?
There was a problem hiding this comment.
Exactly. Now we’ll enable an info icon that, when clicked, will open this modal.
| const getDisplayData = (params: RetryableTask['params']): DisplayData => ({ | ||
| name: params?.filecontent?.name ?? params.plainName ?? params.name, | ||
| type: params?.filecontent?.type ?? params.type, | ||
| size: params?.filecontent?.size ?? params.size, | ||
| modifiedAt: params?.filecontent?.content.lastModified ?? params.updatedAt, | ||
| isFolder: Boolean(params?.isFolder), | ||
| }); |
There was a problem hiding this comment.
I understand that this depends on whether it’s an upload or a download, as the data arrives with the fields structured differently, but this needs to be reorganised more effectively, as looking at it like this, we can’t tell why there are so many fallback options for the same field.
Looking at this code alone, it’s impossible to tell why, for ‘name’, it checks ‘filecontent.name’, then uses ‘params.plainname’ as a fallback, and then ‘params.name’.
Introduce RetryableTaskType and RetryableTaskStatus enums in RetryManager and use them across the network layer, upload thunks, and task components. Split TaskToRetryItem's getDisplayData into typed upload/download variants so each task type maps its own params shape.
| <TaskLoggerButton onClick={() => downloadItem(file)} Icon={RestartIcon} sizeClassName="h-8 w-8" iconSize={16} /> | ||
| )} | ||
| {!isNotAllowed && status === RetryableTaskStatus.Retrying && ( | ||
| <CircleNotch size={16} className="mr-2 animate-spin text-gray-60" weight="bold" /> |
There was a problem hiding this comment.
Change it to Spinner; CircleNotch is deprecated
|
terrerox
changed the title
14e2d9c
into
feat/folder-upload-partial-failure-retry
3 participants
Description
Retry entries are grouped under their parent folder task via relatedTaskId, and non-retryable files show a "Not allowed" label (added to all locales) instead of a retry button.
Also normalizes the two RetryableTask param shapes in TaskToRetryItem behind a getDisplayData helper (file names now display with their extension), tightens the retry modal row padding, and adds sizeClassName/iconSize props to TaskLoggerButton.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes