[_]: refactor/extract-checkout-price-refetch-hook - #2104
Draft
sg-gs wants to merge 2 commits into
Draft
Conversation
Regression guard for the checkout tax flash fixed in a773b23: the debounced refetch that recalculates tax when the billing address changes now lives in usePriceRefetchOnAddressChange, with unit tests covering the missing-country and missing-postal-code cases that caused the bug.
Deploying drive-web with
|
| Latest commit: |
afe52e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76e10b48.drive-web.pages.dev |
| Branch Preview URL: | https://fix-checkout-tax-refetch-hoo.drive-web.pages.dev |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracts the price/tax refetch effect triggered by billing address changes into
usePriceRefetchOnAddressChange(fix applied in #2103), with unit tests covering the cases that caused the tax flash.Why
The bug in #2103 wasn't caught by any test because that logic lived inline in
CheckoutViewWrapperwith no coverage. Extracting it into a hook makes it testable and prevents a future regression.