feat(data): Tashkeela++ fetcher, rebased onto current main (modernizes #1) - #185
Merged
Conversation
added 2 commits
September 5, 2026 12:45
Replaces the env-var placeholder in scripts/fetch_data.sh with a proper Python fetcher that knows the canonical dataset locations. Primary source: Misraj/Sadeed_Tashkeela — gated, requires HF_TOKEN. Fallback: community-datasets/tashkeela — GPLv2 open access. The fetcher streams parquet → one-line-per-chunk text, skips blank and overlong lines, writes atomically via .tmp rename, and exits with a clear error message on gated-repo failures (including the URL the user must visit to grant access). Also adds pythonpath = ["src", "."] to pytest config so tests run without pip install -e ., and pyarrow>=15.0 to [publish] extras. Smoke-tested end-to-end: fetch 100 lines → RababaArabicData consumes them → (bare, diacritized) pairs ready for StudentTrainer.
Drops Misraj/Sadeed_Tashkeela (gated, requires manual approval) as the primary source. Replacement: arbml/tashkeelav2 — open-access, pre-split into train/test, and pre-paired (each row has both `text` and `diacratized` columns). No HF_TOKEN, no acceptance click-through. Output format is now TSV with two columns: `bare<TAB>diacritized`. The data module reads both directly — no in-pipeline stripping needed, and the dataset's canonical letter forms are preserved. Falls back to the legacy single-text path (.txt + strip_diacritics) when only raw community-datasets/tashkeela is available. Layout: primary = arbml/tashkeelav2 (TSV, open) fallback = community-datasets/tashkeela (TXT, GPLv2 raw) New tests: - fetcher primary is open + uses TSV - fetcher fallback still uses raw text path - data module reads TSV pairs (bare+diacritized) - data module falls back to legacy .txt when no TSV - data module prefers TSV when both exist 46 tests pass; smoke-tested against arbml/tashkeelav2 end-to-end.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernization of #1 (the Tashkeela++ fetcher, month-stale): rebased cleanly onto current main (the original branch was 30+ commits behind), ruff green, tests are network-free by design (import + local-parsing coverage only).
No content changes to the owner's commits — this is the same two commits (HF fetcher + the arbml/tashkeelav2 switch), replayed on current main so CI can run. If green, merge this and #1 can be closed as superseded-by-rebase, or this branch pushed to the original head.