Skip to content

Fix incompatibilities with pre-OAuth2 version of Server Manager - #409

Merged
isc-klu merged 4 commits into
intersystems:masterfrom
isc-klu:support-old-server-manager-and-vscode-objectscript
Aug 10, 2026
Merged

Fix incompatibilities with pre-OAuth2 version of Server Manager#409
isc-klu merged 4 commits into
intersystems:masterfrom
isc-klu:support-old-server-manager-and-vscode-objectscript

Conversation

@isc-klu

@isc-klu isc-klu commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Enable strictNullChecks and fix a Server Manager compatibility bug

Functional changes

  • [client/src/extension.ts]: Patch ServerManagerAPI for compatibility with pre-OAuth2 versions of Server Manager: Construct a BasicAuthorization when Server Manager doesn't supply an auth object.
  • [tsconfig.base.json]: Enable strictNullChecks, so mistakes like the ones above get caught by the compiler instead of at runtime.

Non-functional changes

Everything else is mechanical fallout from enabling strictNullChecks, limited to:

  • Adding a missing type annotation.
  • Loosening a type annotation to include undefined/null where that reflects actual runtime behavior.
  • Adding non-null assertions (!) to values of which the type is nullable.

No behavior changes outside the items listed above.

@isc-klu isc-klu changed the title Fix buggy code that assumes Server Manager >= 3.14.0 Fix incompatibilities with pre-OAuth2 version of Server Manager Aug 7, 2026
@isc-bsaviano
isc-bsaviano marked this pull request as ready for review August 10, 2026 16:28
@isc-bsaviano
isc-bsaviano self-requested a review as a code owner August 10, 2026 16:28
@isc-klu
isc-klu merged commit 440d76c into intersystems:master Aug 10, 2026
11 checks passed
@isc-klu
isc-klu deleted the support-old-server-manager-and-vscode-objectscript branch August 10, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants