V1.9.19 updates - #55
Merged
hkimura-intersys merged 2 commits intoSep 1, 2026
Merged
Conversation
the scanner was including whitespace as part of the token returned, which caused injections not to match in cases with whitespace. this fixes that. Also fixed scanner parsing in playground mode. If the potential tag is a statement, it checks if there is whitepsace, and if there is one space followed by a statement, it still counts as a tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR include bug fixes and improvements.
Scanner changes
In a potential tag, if the name is a statement, the scanner looks ahead to see if there is exactly one space followed by another name, and it reads that name. If that name is a statement, then the potential tag is returned and tokenized as a tag. This fixed scenarios where people use statement names as their tags.
Ex:
close set x = 2
When the mimetype keyword value is scanned, whitespace is first scanned so it is no longer included in the token. Before, if there was whitespace, it got included in cases where the scanner returned it, and that made it so injections didn't match properly.
Grammar changes