[deploy] Add enable_metric flag for DSS + fetch pod metrics in prometheus#1506
Open
the-glu wants to merge 5 commits into
Open
[deploy] Add enable_metric flag for DSS + fetch pod metrics in prometheus#1506the-glu wants to merge 5 commits into
the-glu wants to merge 5 commits into
Conversation
the-glu
force-pushed
the
dss_monitoring_flag
branch
from
8a95ffe to
371fb3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the
enable_metricflag in general deploy stack (terraform, helm, tanka).It set the flag + add annotation for prometheus collection.
Promethus pod collection (instead of just services) as been enabled, as each DSS instance own metrics need to be collected, not as a whole for a service (e.g.: http metrics are individual).
Follow #1505