Skip to content

Configure generated NetRID flight data#1543

Merged
BenjaminPelletier merged 2 commits into
interuss:mainfrom
vgrafe:vgrafe/netrid-generated-flight-source-config
Jul 24, 2026
Merged

Configure generated NetRID flight data#1543
BenjaminPelletier merged 2 commits into
interuss:mainfrom
vgrafe:vgrafe/netrid-generated-flight-source-config

Conversation

@vgrafe

@vgrafe vgrafe commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add num_flights and duration knobs to adjacent circular NetRID flight generation
  • preserve the existing default behavior of 6 generated flights with 30 telemetry samples each
  • add tests for default generation, configured generation, and invalid count/duration values
  • regenerate the AdjacentCircularFlightsSimulatorConfiguration JSON schema

Motivation

Follow-up to #1533, scoped to reusable model support only. Project-specific NetRID baseline data/config changes belong in downstream project configuration, but monitoring can still expose the simulator controls needed by those downstream configurations.

Validation

  • PYTHONPATH=../.. ../../.venv/bin/pytest resources/netrid/flight_data_resources_test.py (9 passed)
  • cd schemas && make lint (no JSON Schema updates necessary)
  • make lint
  • git diff --check origin/main...HEAD

@BenjaminPelletier

Copy link
Copy Markdown
Member

This PR seems good, but the Draft status communicates it's not ready for review yet -- were you planning to add or adjust anything else?

Validation

  • PYTHONPATH=../.. ../../.venv/bin/pytest resources/netrid/flight_data_resources_test.py
  • schemas lint attempted after the amend, but Docker was unavailable: failed to connect to the docker API at unix:///Users/vincent.grafe/.docker/run/docker.sock

Currently, docker is a critical tool for almost everything in this repository; I would highly recommend making sure it's installed, working, and available to any AI agent that may be assisting. I believe podman can be used instead of the tool available from Docker if needed.

@vgrafe
vgrafe marked this pull request as ready for review July 23, 2026 16:21
@vgrafe

vgrafe commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @BenjaminPelletier, the PR is ready for review now.

@BenjaminPelletier
BenjaminPelletier merged commit f22f118 into interuss:main Jul 24, 2026
23 checks passed
github-actions Bot added a commit that referenced this pull request Jul 24, 2026
Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com> f22f118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants