#292 Add integration tests for PDF signing pipeline#293
Merged
Conversation
Add 33 tests covering SignerLogic.signFile() using PDFBox + BouncyCastle CMS for independent signature validation. Tests cover hash algorithms, key types, metadata, certification levels, append mode, visible signatures, and multiple signatures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add font-aware text extraction to PdfSignatureValidator using PDFBox font decoding (PDFont.toUnicode) to properly handle subset font encoding in appearance streams. Extend VisibleSignatureSigningTest from 3 to 5 tests covering rectangle position, page number, L2 text placeholder substitution, and default appearance text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SignerLogic.signFile()— the core signing pipeline that previously had zero test coverageTest Coverage
BasicSigningTestHashAlgorithmSigningTestKeyTypeSigningTestSignatureMetadataTestCertificationLevelSigningTestAppendModeSigningTestVisibleSignatureSigningTestMultipleSignaturesTestTest plan
mvn clean verify— 35 tests (2 existing + 33 new), 0 failures, 0 errorsCloses #292
🤖 Generated with Claude Code