Skip to content

43 - file-scoped reusable variables for test file - #53

Merged
worldjoe merged 3 commits into
intuit:masterfrom
someOne404:fix/43-reusable-vars
Nov 1, 2021
Merged

43 - file-scoped reusable variables for test file#53
worldjoe merged 3 commits into
intuit:masterfrom
someOne404:fix/43-reusable-vars

Conversation

@someOne404

@someOne404 someOne404 commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

Related to #43
Extracted file-scoped reusable variables for executor.test.js. Moved repeated code into beforeEach block.

  • Does all of your new or changed code have unit tests?
  • Is overall unit test statement coverage still above 85%?
  • Is code style linting passing with npm run lint?
  • Is the related GitHub issue number included in your branch name? ex branch name: fix/12-some-bug
  • Is the related GitHub issue number included in your pull request title? example PR title: "12 - Fixes some bug"
  • Is documentation still up to date after your change?

@someOne404

Copy link
Copy Markdown
Contributor Author

@worldjoe will this one be reviewed? If this is not qualified I can close it.

@worldjoe
worldjoe merged commit 95dbc44 into intuit:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants