components: adds toggle filter component #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
reviewed
Oct 21, 2020
|
|
||
| render() { | ||
| return( | ||
| <Overridable id={'ToggleComponent'}> |
Member
There was a problem hiding this comment.
Are you sure the overridable id is ok to be the same as the name of the component here ? Also, we will need to pass down the props i.e <Overridable id={'ToggleComponent'}> {...this.props} so they can be available when you override the component I think....
Glignos
force-pushed
the
add_toggle_filter_element
branch
2 times, most recently
from
0720535 to
9a6f9bb
Compare
ntarocco
approved these changes
Oct 22, 2020
Contributor
ntarocco
left a comment
ntarocco
left a comment
There was a problem hiding this comment.
LGTM!
Minor: it would be great if you create a new doc page, even empty, only title, so that at some point we document this component too and it is not forgotten!
src/lib/components/Toggle/Toggle.js
Outdated
| } | ||
|
|
||
| _isChecked = (userSelectionFilters) => { | ||
| let isFilterActive = !_isEmpty(userSelectionFilters.filter( |
Contributor
There was a problem hiding this comment.
Suggested change
| let isFilterActive = !_isEmpty(userSelectionFilters.filter( | |
| const isFilterActive = userSelectionFilters.filter(...).length > 0 |
src/lib/components/Toggle/Toggle.js
Outdated
| class ToggleComponent extends Component{ | ||
| constructor(props) { | ||
| super(props); | ||
| this.title = props.title; |
Contributor
There was a problem hiding this comment.
very minor: because of a "bad" habit, we started doing this in the constructor... it is probably not needed, and props can be used directly. Feel free to improve code! :)
Glignos
force-pushed
the
add_toggle_filter_element
branch
from
9a6f9bb to
53c84e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.