Migrate to React 18#298
Open
mirekys wants to merge 4 commits intoinveniosoftware:masterfrom
Open
Conversation
* Upgrade React peer dependencies from ^16.13.0 to ^18.3.0 * Replace enzyme-adapter-react-16 with @cfaester/enzyme-adapter-react-18, update test setup * Remove explicit React imports - new JSX transform * Migrate pure class components to function components * Replace legacy ReactDOM.render in demos with createRoot().render * Move Bootstrap side effects from constructor to componentDidMount for StrictMode compatibility * Update minimum Node.js engine requirement from >=14.0.0 to >=18.0.0 * Update ESLint configuration to React 18 * Related: inveniosoftware/rfcs#112
Apply consistent formatting across source files following updated ESLint React 18 configuration. Refs inveniosoftware/rfcs#112
17 tasks
* Switches CI to inveniosoftware/workflows JS test workflow for consistency across packages * Removes unused devDependencies (cheerio, coveralls, expect) * Adds npm overrides for supply chain security and Node 22+ compatibility * Adds MessagePort and MessageChannel to test polyfills for React 18 act() scheduling in JSDOM * Removes redundant `expect` import (provided by Jest)
9f8bd52 to
d55223b
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Migrate react-searchkit from React 16 to React 18 following RFC inveniosoftware/rfcs#112.
Prerequisites
To make React 18 linting work, you need to link a local clone of eslint-config-invenio:
In this repo:
npm auditdown to just 2 moderate severity vulnerabilities (due towebpack-dev-server- didn't manage to solve that one)Requires:
Part of: inveniosoftware/rfcs#112
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend