Skip to content

Improvements to PrintingOptionsSerializer - #12434

Merged
SchrodingersGat merged 2 commits into
inventree:masterfrom
fuzeman:label-printing
Jul 23, 2026
Merged

Improvements to PrintingOptionsSerializer#12434
SchrodingersGat merged 2 commits into
inventree:masterfrom
fuzeman:label-printing

Conversation

@fuzeman

@fuzeman fuzeman commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Provides support for printing options serializer to retrieve the current machine options. This can be used for option dependancies or defaults.

inventree/inventree-brother-plugin#77

@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit a70aad2
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/6a601736e2bc3500098fd28b

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (7973057) to head (a70aad2).
⚠️ Report is 6 commits behind head on master.

❌ Your project check has failed because the head coverage (88.19%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12434      +/-   ##
==========================================
- Coverage   86.88%   84.79%   -2.09%     
==========================================
  Files        1442     1442              
  Lines       94723    98055    +3332     
  Branches    11200    11200              
==========================================
+ Hits        82296    83142     +846     
- Misses      12362    14848    +2486     
  Partials       65       65              
Flag Coverage Δ
backend 91.08% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 88.19% <100.00%> (-4.50%) ⬇️
Backend General 93.49% <ø> (ø)
Frontend 79.56% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SchrodingersGat

Copy link
Copy Markdown
Member

@fuzeman please address failing tests

@fuzeman
fuzeman force-pushed the label-printing branch 2 times, most recently from aff6695 to 51f23d1 Compare July 21, 2026 03:17
@fuzeman

fuzeman commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@fuzeman please address failing tests

All good now.

@SchrodingersGat

Copy link
Copy Markdown
Member

Is there a way to add a unit test here?

@fuzeman
fuzeman force-pushed the label-printing branch 3 times, most recently from 6478bf7 to 6b867eb Compare July 22, 2026 00:36
@fuzeman

fuzeman commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

I've added a unit test, just trying to fix up the remaining test failures. Note the extra change at f5f9249, which is required to fix defaults not being applied to print options.

@SchrodingersGat
SchrodingersGat merged commit 346d7e0 into inventree:master Jul 23, 2026
40 of 42 checks passed
@SchrodingersGat

Copy link
Copy Markdown
Member

@fuzeman thanks for the improvements here

@SchrodingersGat SchrodingersGat added plugin Plugin ecosystem report Report/Label generation labels Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin Plugin ecosystem report Report/Label generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants