Refactor resolve request

[notaphplover]

Description

• _resolveRequest function has been refactored to extract a _resolveBinding function.
• Added generic T type to resolveInstance call at _resolveRequest.
• Renamed Binding T generic to TActivated.
• Updated Binding.factory to be FactoryCreator<TActivated> | null.

Related Issue

#1321, #1322

Motivation and Context

This change reduces the code complexity of the _resolveRequest funcion and also adds more concrete types

How Has This Been Tested?

• Code compiles
• All test passes successfully

Types of changes

• Updated docs / Refactor code / Added a tests case (non-breaking change)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the changelog.

[PodaruDragos]

Nice work, LGTM sâm., 1 mai 2021, 12:19 notaphplover ***@***.***> a scris:

…

@notaphplover <https://github.com/notaphplover> requested review from @inversify/maintainers on: #1323 <#1323> Refactor resolve request. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1323 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU32VIT66DITBILSGQOFULTLPBTJANCNFSM436EJELQ> .

[notaphplover]

There's a test failing on node 14 (es6), I'll have a look but I'll be missing for some hours. @tonyhallett could you have a look?

EDIT: if it actually sounds rude, I'm just asking a favor 😃 (english is not my first language, sry)

[notaphplover]

Great! I think it's possible to reduce the complexity of those functions, I can go for it this night

[tonyhallett]

@notaphplover @PodaruDragos Ok to squash and merge ?

[tonyhallett]

done making changes

[notaphplover]

done making changes

I'm back at home, on my way to review it :)

[notaphplover]

Ok I have some changes to request, I already have them unstaged on my local repo so if you agree I can easily push them

[notaphplover]

These are the changes :)

[tonyhallett]

Ok I have some changes to request, I already have them unstaged on my local repo so if you agree I can easily push them

Please do !

[tonyhallett]

Only other thing that could be done is to further replace T with TActivated. I personally don't mind if we do this at a later stage.

[notaphplover]

LGTM! I think we can squash and merge once the changelog has the BCs!

[tonyhallett]

Ok can I leave that with you ?

[notaphplover]

Ok can I leave that with you ?

I said to add BC to the changelog because I read #1319, but im not sure now. I think the cache refactor task is the right one

[notaphplover]

So, I think we can squash and merge now, Ill do it this afternoon, once Im at home :)