'pub' errors during melos commands on Windows

[Boehrsi]

I'm getting 'pub' related errors during melos command execution ('pub' command is missing), probably related to the direct usage of pub instead of dart pub or flutter pub. I found this PR (https://github.com/invertase/melos/pull/18/files) which should fix exactly this problem.

Flutter 1.27.0-1.0.pre • channel dev • https://github.com/flutter/flutter.git
Framework • revision 68c96f100e (9 days ago) • 2021-02-08 16:14:15 -0800
Engine • revision b04955656c
Tools • Dart 2.13.0 (build 2.13.0-0.0.dev)
Microsoft Windows [Version 10.0.19041.804]
melos 0.4.5

• dart pub and flutter pub are working fine

Steps to reproduce

• Execute any melos command (even the help command works)
• See output (error can be found at the end. Sorry for the German error message. It just says that 'pub' isn't there, which is true, but dart pub and flutter pub should be used)

D:\Code\Flutter>melos
Your current directory does not appear to be a valid Melos workspace.

You must have one of the following to be a valid Melos workspace:
   - a "melos.yaml" file in the root with a "packages" option defined
   - a "packages" directory
Der Befehl "pub" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.

Is there something I'm missing during configuration / setup or is this a bug?

[Salakar]

Strange, CI does run Windows currently and uses the new dart pub executable.

Your current directory does not appear to be a valid Melos workspace.

You must have one of the following to be a valid Melos workspace:
   - a "melos.yaml" file in the root with a "packages" option defined
   - a "packages" directory

Is this log above valid, do you not have any of those 2 requirements?

There's a visual bug when when running https://github.com/TimWhiting/melos/blob/16c5e4dab15135ab1a571a46331dbfdaa05b6f85/packages/melos/lib/src/common/utils.dart#L281 - this still prints the logs of the sub process, such as in this case - but this is still just visual afaik.

[Boehrsi]

That's actually strange and yes the output is valid. I tried a completely empty folder to eliminate possible errors in the melos.yaml of the project.

If I execute it in a valid repository (with a Melos configuration) via e.g. Powershell I get:

PS D:\Code\Flutter\plus_plugins> melos
A CLI tool for managing Dart & Flutter projects with multiple packages.

Usage: melos <command> [arguments]

Global options:
-h, --help                                       Print this usage information.
    --verbose                                    Enable verbose logging.
    --no-private                                 Exclude private packages (`publish_to: none`). They are included by
                                                 default.
    --[no-]published                             Filter packages where the current local package version exists on
                                                 pub.dev. Or "-no-published" to filter packages that have not had their
                                                 current version published yet.
    --[no-]nullsafety                            Filter packages where the current local version uses a "nullsafety"
                                                 prerelease preid. Or "-no-nullsafety" to filter packages where their
                                                 current version does not have a "nullsafety" preid.
    --[no-]flutter                               Filter packages where the package depends on the Flutter SDK. Or
                                                 "-no-flutter" to filter packages that do not depend on the Flutter SDK.
    --scope=<glob>                               Include only packages with names matching the given glob. This option
                                                 can be repeated.
    --ignore=<glob>                              Exclude packages with names matching the given glob. This option can be
                                                 repeated.
    --since=<ref>                                Only include packages that have been changed since the specified `ref`,
                                                 e.g. a commit sha or git tag.
    --dir-exists=<dirRelativeToPackageRoot>      Include only packages where a specific directory exists inside the
                                                 package.
    --file-exists=<fileRelativeToPackageRoot>    Include only packages where a specific file exists in the package.
    --depends-on=<dependantPackageName>          Include only packages that depend on a specific package. This option
                                                 can be repeated.
    --no-depends-on=<noDependantPackageName>     Include only packages that *don't* depend on a specific package. This
                                                 option can be repeated.

Available commands:
  bootstrap   Initialize the workspace, link local packages together and install remaining package dependencies.
              Supports all package filtering options.
  clean       Clean this workspace and all packages. This deletes the temporary pub & ide files such as ".packages" &
              ".flutter-plugins". Supports all package filtering options.
  exec        Execute an arbitrary command in each package. Supports all package filtering options.
  list        List local packages in various output formats. Supports all package filtering options.
  publish     Publish any unpublished packages or package versions in your repository to pub.dev. Dry run is on by
              default.
  run         Run a script by name defined in the workspace melos.yaml config file.
  version     Automatically version and generate changelogs based on the Conventional Commits specification. Supports
              all package filtering options.

Run "melos help <command>" for more information about a command.
Der Befehl "pub" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.

The last two lines are actually the relevant parts.

But if this is only visual, it's just a minor problem I would say. In general Melos seems to work, I just had problems with a specific repository with Melos and wasn't sure if the problem are the used commands in the Melos config or Melos itself.
I will then have a look into the config file and scripts within the project. 👍

[Boehrsi]

Just checked with the current local build (removed the pub installation and activated the new one like described - https://github.com/invertase/melos#local-development-setup) and I get:

D:\Code\Flutter\melos>dart pub global activate --source="path" . --executable="melos"
Resolving dependencies...
 args 1.6.0 (2.0.0 available)
 cli_util 0.2.0 (0.3.0 available)
 file 5.2.1 (6.1.0 available)
 glob 1.2.0 (2.0.0 available)
 http 0.12.2 (0.13.0 available)
 http_parser 3.1.4 (4.0.0 available)
 pub_semver 1.4.4 (2.0.0 available)
 quiver 2.1.5 (3.0.0 available)
 yaml 2.2.1 (3.0.0 available)
Warning: You are using these overridden dependencies:
! ansi_styles 0.2.0 from path packages\ansi_styles
! conventional_commit 0.3.0 from path packages\conventional_commit
! melos 0.4.5 from path packages\melos
Got dependencies!
Package melos_monorepo is currently active at path "D:\Code\Flutter\melos".
Installed executable melos.
Activated melos_monorepo 0.0.0 at path "D:\Code\Flutter\melos".

D:\Code\Flutter\melos>melos --help
Der Befehl "pub" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.

Which actually doesn't look right, doesn't it?

[Boehrsi]

And another update (sorry for the spam), I just downgraded from my Flutter dev version to Flutter stable and the error went away, so it seems something changed in that area. I think this isn't a Melos error, so it would be fine for me to just close this issue. If you want to keep it open to further test if you also can reproduce this problem against the dev channel or something simliar, feel free to do so.
Sorry again for the confusion.