feat: add ability to disable nonce - #52
Conversation
mikehardy
left a comment
There was a problem hiding this comment.
I don't see why not - I know plumbing nonce through was something everyone had to do semi-unexpectedly for it to work and caused a PR to the expo apple auth as well (firebase requires nonce, so that drove it). So I can see the need and the code looks fine to me. I'll leave for @Salakar to merge in case he knows a reason not to
|
@dougkeen I'm happy to add this in so thanks for this PR - it does though look like you're missing https://github.com/invertase/react-native-apple-authentication/blob/master/lib/AppleAuthModule.js#L60 Without this I think it will cause a native crash here: https://github.com/invertase/react-native-apple-authentication/pull/52/files#diff-c1c850227210d2e412283742bab2ec03R44 as it'd try to call |
|
@Salakar Good call. I definitely missed that bit in the javascript where the defaults are set and type-checked. FYI, in Obj-C messages sent to |
|
@Salakar I believe this is ready for merge if your concerns are addressed? (they seem to be) |
|
Thank you :) |
This is useful if you use a platform like Auth0, whose Apple token exchange flow doesn't currently support nonces.
With this change, you can disable nonces like so: