Updating invoiceninja to new version is not possible with debian docker-compose.yml

[benbrummer]

Setup information

docker run / docker-compose / Helm

Describe the bug
invoiceninja stays on the version, which initialy created the volume, cause of https://github.com/invoiceninja/dockerfiles/blob/debian/debian/docker-compose.yml#L19

To reproduce
Steps to reproduce the behavior:

1. Clone https://github.com/invoiceninja/dockerfiles.git -b debian
2. cd to dockerfiles/debian
3. Set image tag to 5.10.56
4. docker compose up
5. docker compose down
6. Change image tag to latest again
7. docker compose up => docker will stay on 5.10.56

Expected behavior
invoiceninja is using the version defined in docker-compose.yml

[benbrummer]

Basically on the first start the volumes/directories are populated with the files from the image. New files, will be added if a newer tag contains new files at that location. Old/existing files will not be updated anymore after initialization.

I just checked the previous docker-compose.yml file. A similar behaviour can be seen there

dockerfiles/docker-compose.yml

Line 31 in 9941847

- ./docker/app/public:/var/www/app/public:rw,delegated

After many updates the public directory contains 2845 files

/opt/invoiceninja/docker/app/public# ls -1 | wc -l
2845

Without mounting the public folder it contains just 585 files

/var/www/html/public# ls -1 | wc -l
585

[turbo124]

this should resolve the issue: #651

this will use the images public/ directory not the volume.

[benbrummer]

#651 will fix the update issue, but not the continously growing public directory. Files like the index.php will never receive an update, only new files will be taken into account.

[turbo124]

With this change we do not store anything other than the storage folder. Everything else is baked into the image itself.

So the public directory won't grow except your own files that are uploaded

[benbrummer]

dockerfiles/debian/docker-compose.yml

Line 19 in 3fca330

- image-public:/var/www/html/public:ro

mounts the public directory as read only and will fail the deployment.

app-1     | cp: can't create '/var/www/app/public/useResolveCurrencySeparator-30f43bed.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/useShowEditOption-4936ae30.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/useSumTableColumn-16ef5d64.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/useTaskColumns-18a44495.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/utc-07806bdd.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/uz-6a2aa1f1.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/uz-latn-decee507.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/vb-77962f32.js': Read-only file system
app-1     | cp: can't create directory '/var/www/app/public/vendor': Read-only file system
app-1     | cp: can't create '/var/www/app/public/version.json': Read-only file system
app-1     | cp: can't create '/var/www/app/public/vi-0a4183d1.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/vi-56bbb11d.json': Read-only file system
app-1     | cp: can't create '/var/www/app/public/wgsl-e67d25e4.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/x-pseudo-6200fd6d.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/xml-e6335c8f.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/yaml-bcea1b2b.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/yo-95dcdde7.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/zh-51fc9c3b.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/zh-cn-67400750.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/zh-hk-90b238bd.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/zh-tw-246dacfb.js': Read-only file system
app-1     | cp: can't create '/var/www/app/public/zh_TW-0515ce5e.json': Read-only file system
app-1     | cp: can't create '/var/www/app/public/zh_TW-ca98e0c4.js': Read-only file system

If write would be allowed modified files will not be updated.

diff public/version public.bak/version
1c1
< 5.10.57
---
> 5.10.48

We will end up with a evergrowing public directory as described here #649 (comment)

So the public directory won't grow except your own files that are uploaded
The uploads will end up in public/storage, which from the documentation should be a symlink to /var/www/html/storage/app/public https://laravel.com/docs/11.x/structure#the-storage-directory. So public folder will not grow with uploads. https://laravel.com/docs/11.x/filesystem#the-public-disk => php artisan storage:link

~ $ php artisan storage:link

   INFO  The [public/storage] link has been connected to [storage/app/public].

Here instead of a symlink a real folder is created

dockerfiles/debian/scripts/init.sh

Line 39 in 3fca330

/var/www/html/public/storage

So we need to find a different way to share the public folder between the app and nginx.

[turbo124]

I cannot recreate the issue you are seeing. With a completely fresh installation, the containers boot and work as expected.

The symlink, is just a refernence to /public the files are only being written to storage.

[benbrummer]

@turbo124 seems you are correct. Looks like I messed something up with the migration from master => debian.

Starting from scratch with docker volumes works, only the symlink inside nginx is invalid

[turbo124]

That symlink looks correct I believe:

Source: /var/www/html/storage/app/public
Target: /var/www/html/public/storage

I do see an issue however when attempting to reach files directly with nginx which may be a path issue.

[turbo124]

#653

fixes the issue with symlinks. My testing shows public/storage files are now accessible as expected

[benbrummer]

#653

fixes the issue with symlinks. My testing shows public/storage files are now accessible as expected

For me the symlink only works if i add the app_storage as volume to nginx

  nginx:
    image: nginx:alpine
    restart: unless-stopped
    ports:
      - "127.0.0.1:81:80"
    volumes:
      - ./nginx/conf.d:/etc/nginx/conf.d:ro
      - ./nginx/nginx.conf:/etc/nginx/nginx.conf:ro
      - app_storage:/var/www/html/storage:ro
      - image-public:/var/www/html/public:ro