fix: tolerate stale object cache eviction entries - #9371
Open
Sanjays2402 wants to merge 2 commits into
Open
Conversation
Deleting a cached object leaves its queued eviction identifier behind. Ignore that stale identifier when it reaches the front of the queue, and cover the reported delete-then-save sequence.
Sanjays2402
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
July 22, 2026 01:14
github-actions
Bot
added
python
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix stale object-cache eviction IDs causing
save()to raiseKeyErrorafter a cached object is deleted. Eviction now ignores an ID that was already removed, with a regression covering the reported delete-then-save sequence.Related Issues / Discussions
Closes #9370
QA Instructions
Run
pytest tests/test_object_serializer_disk.py::test_obj_serializer_fwd_cache_save_after_deleting_cached_object.Merge Plan
N/A
Checklist
What's Newcopy (if doing a release after this PR)