docs(config): disclose legacy device precedence in generation_devices auto copy - #9388
Open
lstein wants to merge 1 commit into
Open
docs(config): disclose legacy device precedence in generation_devices auto copy#9388lstein wants to merge 1 commit into
lstein wants to merge 1 commit into
Conversation
github-actions
Bot
added
api
python
5 tasks
lstein
force-pushed
the
lstein/fix/multigpu-auto-devices-copy
branch
from
July 29, 2026 22:39
51d25a1 to
4ab4d84
Compare
Collaborator
Author
|
Rebased cleanly onto the current #9263 head ( |
… auto copy The schema description, Settings UI copy, and configuration guide's behavior table all said `generation_devices: auto` uses every available GPU, but TorchDevice.get_generation_devices() deliberately resolves it to the single pinned legacy `device` when one is set — only a later docs note disclosed the exception. An upgraded install with `device: cuda:1` displayed "Auto (all GPUs)" while starting one worker. - config_default.py: the field description now states the precedence (and that an explicit list overrides `device`). - Settings UI: the badge is "Auto" (not "Auto (all GPUs)") and the help text explains the legacy-device exception and the override. - invokeai-yaml.mdx: the behavior table row for `auto` states the exception where the value is introduced, not only in the notes. - Regenerated docs/src/generated/settings.json, openapi.json, schema.ts from the description source. - New test asserts all four copy locations describe the precedence. Follow-up to PR invoke-ai#9263 (JPPhoto review, 2026-07-25). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lstein
force-pushed
the
lstein/fix/multigpu-auto-devices-copy
branch
from
July 30, 2026 01:18
4ab4d84 to
0878863
Compare
lstein
marked this pull request as ready for review
July 30, 2026 01:41
lstein
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant and
dunkeroni
as code owners
July 30, 2026 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9263, addressing the misleading
generation_devices: autocopy deferred in @JPPhoto's 2026-07-25 review:config_default.py): now states thatautouses only the pinned legacydevicewhen one is set, and that an explicit list overridesdevice.en.json): the badge reads "Auto" instead of "Auto (all GPUs)", and the help text explains the legacy-device exception and the override.invokeai-yaml.mdx): the behavior table row forautostates the exception where the value is introduced, not only in the notes further down.docs/src/generated/settings.json,openapi.json, andschema.tsfrom the description source.Test
test_auto_copy_documents_legacy_device_precedenceasserts all four copy locations (field description, generated settings.json, en.json, docs behavior table) describe the precedence, so the copy cannot silently regress out of sync withget_generation_devices()again. The behavioral test for the resolution itself (test_get_generation_devices_auto_respects_pinned_legacy_device) already exists on #9263.Merge order
Stacked on #9263 — this branch contains the multi-GPU branch's commits. Draft until #9263 merges; will then rebase onto main and mark ready for review.
Checklist
What's Newcopy (if doing a release after this PR)🤖 Generated with Claude Code