Feat: upgrade hdf5 to 1.0.0 and e2e fixtures#4
Merged
Conversation
Upgrade HDF5 loading to the published initHdf5({ wasmBinary }) API for
inline workers, add checked-in test fixtures with generation scripts, and
remove skipped/conditional E2E tests so CI runs a stable 347+29 suite.
Use patch semver for HDF5/fixture fixes without public API changes, and update index.html canonical/hreflang/OG links from io-ai.tech/rosview to rosview.com.
Resolve version conflicts keeping 1.3.2 on top of ioai-tech/rosview main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adopts
@ioai/hdf5@^1.0.0and simplifies HDF5 loading to use the library’s publicinitHdf5({ wasmBinary })API for inline (?worker&inline) workers. The main thread fetches the published wasm asset via@ioai/hdf5/wasm/ioai_hdf5.wasm?urland passes the bytes into the HDF5 worker at initialize time—no deep imports of@ioai/hdf5/dist/*and no wasm URL resolution inside blob workers.Also makes E2E tests self-contained and non-skipping:
test-fixtures/(layouts, minimal HDF5/BVH, JPEG/H264 binaries)scripts/gen-e2e-fixtures.mjsand sub-generators; CI/pretest:e2euse the unified entrypointtests/fixturePaths.ts; addstests/bvh-basic.spec.tstest.skip/it.skipIfpatterns from Vitest and E2EOther related fixes:
H5FileSystem: eager-fetch small same-origin HDF5 files (≤32MB) into MEMFS for reliable worker parsingresolveWorkerHttpUrl: resolve relative URLs againstself.location.hreffor inline workersMotivation / related issue
Previously, rosview carried application-layer workarounds for HDF5 in inline workers (deep imports, manual Emscripten glue/wasm URL wiring) because
@ioai/hdf5resolved wasm viaimport.meta.urlat import time, which breaks under blob worker URLs.With
@ioai/hdf5@1.0.0, the supported pattern is:initHdf5({ wasmBinary })This PR aligns rosview with that upstream API and stabilizes CI by removing external-path/skipped E2E dependencies.
Related upstream release:
@ioai/hdf5@1.0.0(hdf5-wasm)Type of change
Checklist
npm run lintpasses with no errorsnpm testpasses (unit tests) — 347 passed, 0 skippednpm run buildandnpm run build:libsucceed —npm run buildverified (build:libnot re-run in this branch; recommend CI/local confirmation before merge)tests/hdf5-basic.spec.tstests/bvh-basic.spec.tsnpm run gen:e2e:fixtures+ full E2E suite (29 passed)docs/DEVELOPMENT.mdfixture workflowAPI compatibility
N/A — no changes to rosview’s exported library API (
src/entrypoints/index.ts). Internal HDF5 worker initialization now expectshdf5WasmBinaryfrom the main thread (same pattern as existingsqlWasmBinaryfor db3).Screenshots / recordings
N/A — no visible UI changes. Functional verification: