feat: loading ux v1.3.3#5
Merged
Merged
Conversation
…r init Show the player shell with a loading overlay and skeleton placeholders instead of the welcome screen during open, add sidebar topic skeletons, and remove the fixed worker initialize timeout so large remote files can load until the user cancels.
Include necessary parser and decompression dependencies in the Vite configuration to enhance the loading experience by preventing unnecessary reloads when opening datasets in development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release v1.3.3 with a clearer file-open loading experience and more reliable worker startup in dev.
LoadingOverlayand removed fromWelcomeScreen.WorkerSerializedSource.initialize()can be aborted; exposesWorkerSourceCancelledError/isWorkerSourceCancelledError().RosViewerImpltears down in-flight init when the user cancels or switches files, without surfacing a false error.optimizeDeps.includeso opening a dataset in dev no longer triggers “new dependencies optimized” reloads that bounce the app back to home.WorkerSerializedSource.test.ts.1.3.2→1.3.3.Motivation / related issue
Opening large MCAP/bag/HDF5 files felt abrupt: the welcome screen disappeared with little feedback, and cancelling or switching files during worker init could leave confusing state. In Vite dev, the first open after adding parser dependencies could trigger a full-page reload.
Follow-up to the v1.3.2 release (HDF5 1.0.0 / E2E fixtures); no linked issue.
Type of change
Checklist
npm run lintpasses with no errorsnpm testpasses (unit tests)npm run buildandnpm run build:libsucceedAPI compatibility
No changes to
src/entrypoints/index.tsexports.Internal worker layer only (additive, non-breaking for embedders):
WorkerSourceCancelledErrorandisWorkerSourceCancelledError()— used when user cancels load; embedders that call worker sources directly may catch this instead of treating it as a failure.Player,PlaybackControlsApi, or public React component props.Screenshots / recordings