This repository was archived by the owner on Nov 28, 2019. It is now read-only.
Conversation
philippjfr
changed the title
jbednar
reviewed
Mar 17, 2017
| kw = dict(tooltip=p_obj.doc, value=value) | ||
|
|
||
| kw = dict(value=value) | ||
| if p_obj.doc: |
Member
There was a problem hiding this comment.
I briefly thought this should be if p_obj.doc is not None:, based on honoring the title of the pull request, but doc==0 isn't a valid docstring and I guess we also want doc=="" to skip installing the tooltip, so I suppose it's better as it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would previously raise errors in some cases because the tooltip cannot be None.