RMET-4099 :: added chooseFromGallery feature#1
Merged
OS-ruimoreiramendes merged 61 commits intofeat/RMET-4099/camera-unificationfrom Mar 17, 2026
Merged
RMET-4099 :: added chooseFromGallery feature#1OS-ruimoreiramendes merged 61 commits intofeat/RMET-4099/camera-unificationfrom
OS-ruimoreiramendes merged 61 commits intofeat/RMET-4099/camera-unificationfrom
Conversation
For better separation and testability
Removing unused files from example-app
Otherwise the camera pages would become extremely large
Otherwise pwa functionality is limited
For page to not grow as large
…/new-capacitor-example-app
Possible issue in saving to file and calling EditURIPhoto on Android with Capacitor plugin, still to be investigated.
To make sure there's no issue with edge-to-edge
OS-pedrogustavobilro
approved these changes
Mar 16, 2026
Contributor
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Overall everything looks good! From what I've been testing these days with the example app the new methods seem to be working well!
Just leaving a comment regarding something that I noticed, but it's non-blocker and we can change later so I'll approve the PR.
OS-pedrogustavobilro
approved these changes
Mar 16, 2026
OS-ruimoreiramendes
merged commit 4c1b429
into
feat/RMET-4099/camera-unification
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.