feat(web): add web implementation for takePhoto and chooseFromGallery#15
Conversation
Context: This code was generated by Claude.
alexgerardojacinto
requested review from
OS-pedrogustavobilro,
OS-ruimoreiramendes and
andredestro
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Haven't gone to testing yet, just leaving comments on things that stood out to me.
Co-authored-by: Pedro Bilro <pedro.gustavo.bilro@outsystems.com>
|
@OS-pedrogustavobilro I think I addressed all your comments. I also update the code to use |
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Some of these comments are things that I noticed from the current code in feat/RMET-4099/camera-unification, that when seeing the Web implementation, maybe it should be tweaked.
Co-authored-by: Pedro Bilro <pedro.gustavo.bilro@outsystems.com>
OS-ruimoreiramendes
left a comment
OS-ruimoreiramendes
left a comment
There was a problem hiding this comment.
Tested in Chrome and everything seems to be working fine
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
A few more comments in relation to this thread - #15 (comment) that was my bad, sorry
|
@OS-pedrogustavobilro no worries! I refactored it accordingly |
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Tested PWA with Android and iOS, everything seems to be working, picture, video and gifs!
I noticed some issues that are coming from PWA elements, but will write those down, since they are not specific to this PR.
This reverts commit c2e8dd1.
|
@OS-pedrogustavobilro thank you for adding those extra things to the example-app! |
alexgerardojacinto
merged commit 378c440
into
feat/RMET-4099/camera-unification
3 participants
Disclaimer: This code was generated by Claude.
Tested in Chrome.