-
Notifications
You must be signed in to change notification settings - Fork 443
docs: update firebase push for spm #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eric-horodyski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jcesarmobile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the "Then, search for firebase-ios-sdk and select it.", you have to click the + button so the prompt on the screenshot appears.
And you can't just search for firebase-ios-sdk, nothing appears, you have to enter the firebase repository url (https://github.com/firebase/firebase-ios-sdk), not just the name. Once it's cached and appears in the "Recently used" then it will appear just by the name, but most users won't have it cached. The screenshot should also be updated to pick from the url, not from "Recently used".
And this should be done on the versioned v6 and v7 too, but let's wait until everything is correct so you don't have to edit all 3 files if more changes are requested.
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
|
Good catch on those bad paths @jcesarmobile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some typos
other than that looks good, so once you fix them you can also make the changes to the v6 and v7 equivalent files
|
|
||
| To add the SDK using SPM, you'll need to make a modification to your `ios/App/App.xcodeproj` | ||
|
|
||
| First, open `ios/App/App.xcodeproj` in Xcode by runnning `npx cap open ios` or double click the file in finder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| First, open `ios/App/App.xcodeproj` in Xcode by runnning `npx cap open ios` or double click the file in finder. | |
| First, open `ios/App/App.xcodeproj` in Xcode by running `npx cap open ios` or double click the file in finder. |
| The Push Notification API on iOS makes use of CocoaPods - an iOS dependency management system - and we need to tell CocoaPods to make use of Firebase. | ||
| ### Add the Firebase SDK | ||
|
|
||
| The Push Notification API on iOS makes use of either Swift Package Manager or CocoaPods for dependency managment. We need to tell them to make use of Firebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The Push Notification API on iOS makes use of either Swift Package Manager or CocoaPods for dependency managment. We need to tell them to make use of Firebase. | |
| The Push Notification API on iOS makes use of either Swift Package Manager or CocoaPods for dependency management. We need to tell them to make use of Firebase. |
Changes are here: https://capacitor-docs-git-firebase-ionic1.vercel.app/docs/next/guides/push-notifications-firebase
closes #419