Skip to content

feat(ios): fix error code and messages #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
Merged

feat(ios): fix error code and messages #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions ios/Sources/InAppBrowserPlugin/OSInAppBrowserError.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,27 @@ enum OSInAppBrowserError: Error {

switch self {
case .bridgeNotInitialised:
result = "Capacitor bridge is not initialized."
result = "Capacitor bridge isn’t initialized."
case .invalidURLScheme:
result = "The provided URL must start with http:// or https://."
result = "The URL provided must begin with either http:// or https://."
case .inputArgumentsIssue(let target):
let targetString: String

switch target {
case .externalBrowser: targetString = "openInExternalBrowser"
case .systemBrowser: targetString = "openInSystemBrowser"
case .webView: targetString = "openInWebView"
let targetString = switch target {
case .externalBrowser: "openInExternalBrowser"
case .systemBrowser: "openInSystemBrowser"
case .webView: "openInWebView"
}

result = "The input parameters for '\(targetString)' are invalid."
result = "The '\(targetString)' input parameters aren't valid."
case .failedToOpen(url: let url, onTarget: let target):
let targetString: String

switch target {
case .externalBrowser: targetString = "Safari"
case .systemBrowser: targetString = "SFSafariViewController"
case .webView: targetString = "WebView"
let targetString = switch target {
case .externalBrowser: "External browser"
case .systemBrowser: "SafariViewController"
case .webView: "The WebView"
}

result = "Couldn't open '\(url)' using \(targetString)."
result = "\(targetString) couldn't open the following URL: '\(url)'"
case .noBrowserToClose:
result = "No browser view to close."
result = "There’s no browser view to close."
}

return result
Expand Down