feat: screen orientation plugin - #1340
Merged
jcesarmobile merged 26 commits intoFeb 22, 2023
Merged
Conversation
IT-MikeS
suggested changes
Jan 4, 2023
IT-MikeS
left a comment
IT-MikeS
left a comment
Contributor
There was a problem hiding this comment.
Added some suggested changes to handle:
- Deprecation in Android
- iOS 16 rotation changes
Please also run npm run fmt in either the root of the capacitor-plugins repo or in screen-orientation sub directory
eric-horodyski
requested review from
IT-MikeS and
giralte-ionic
and removed request for
ItsChaceD,
giralte-ionic and
theproducer
January 5, 2023 20:27
giralte-ionic
approved these changes
Jan 5, 2023
eric-horodyski
requested review from
IT-MikeS and
giralte-ionic
and removed request for
IT-MikeS and
giralte-ionic
January 5, 2023 20:27
IT-MikeS
approved these changes
Jan 6, 2023
jcesarmobile
requested changes
Jan 19, 2023
jcesarmobile
left a comment
jcesarmobile
left a comment
Member
There was a problem hiding this comment.
Added a comment.
Also the PR should have a companion PR on the capacitor-testapp to properly test the plugin functionality
jcesarmobile
requested changes
Feb 2, 2023
jcesarmobile
left a comment
jcesarmobile
left a comment
Member
There was a problem hiding this comment.
I've made some changes to the web implementation, types and some things that were missing.
Android is working fine, but iOS is crashing on iOS < 16, so should be fixed.
jcesarmobile
requested review from
IT-MikeS,
ItsChaceD,
giralte-ionic,
jcesarmobile and
theproducer
February 17, 2023 16:26
jcesarmobile
approved these changes
Feb 17, 2023
giralte-ionic
approved these changes
Feb 20, 2023
IT-MikeS
approved these changes
Feb 20, 2023
This was referenced Aug 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds a
ScreenOrientationplugin using the output of the Capacitor Plugin Tutorial.Unfortunately, there appears to be a change in the way iOS 16 handles screen orientation handling. Looking into it, but help any contributions would be appreciated.