feat(device)!: Change DeviceId.uuid to DeviceId.identifier - #1507
Merged
Conversation
theproducer
requested review from
IT-MikeS,
ItsChaceD,
giralte-ionic,
jcesarmobile and
markemer
March 27, 2023 17:35
jcesarmobile
approved these changes
Mar 27, 2023
jcesarmobile
changed the title
DeviceId.uuid to DeviceId.identifierDeviceId.uuid to DeviceId.identifier
giralte-ionic
approved these changes
Mar 27, 2023
This comment was marked as abuse.
This comment was marked as abuse.
|
How is this not a breaking change? It should at least have been mentioned in the changelog |
Member
|
It is documented as a breaking change in the Capacitor 5 upgrade guide |
This was referenced Aug 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies details of the returned device identifier on Android vs iOS, and renames
DeviceId.uuidtoDeviceId.identifierto avoid confusion.closes: #1152