fix(google-maps): use URLSession for remote iconUrl on iOS - #1818
Merged
Conversation
jcesarmobile
requested review from
IT-MikeS,
ItsChaceD,
giralte-ionic,
markemer and
theproducer
September 27, 2023 16:39
markemer
approved these changes
Oct 2, 2023
markemer
left a comment
markemer
left a comment
Member
There was a problem hiding this comment.
This is a good change. Data is mainly only good for file urls and even apple says:
As this method runs synchronously and blocks the calling thread until it finishes, don’t invoke it from the main thread.
I'm actually a little surprised this ever worked.
IT-MikeS
approved these changes
Oct 3, 2023
jcesarmobile
added a commit
that referenced
this pull request
Oct 3, 2023
jcesarmobile
added a commit
that referenced
this pull request
Oct 3, 2023
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1667