refactor(android)!: Unify gallery cancel message - #1967
Merged
Conversation
jcesarmobile
requested review from
IT-MikeS,
ItsChaceD,
giralte-ionic,
markemer and
theproducer
December 18, 2023 12:34
|
Released dev build of camera with dev version: 6.0.0-dev-1967-20231218T123528.0 |
jcesarmobile
changed the title
giralte-ionic
approved these changes
Dec 18, 2023
theproducer
approved these changes
Dec 18, 2023
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS and web we use
"User cancelled photos app"message for both camera and gallery cancellation, on Android we were using a different message for gallery cancellation.Unify the messages so they are the same in all platforms.
Use a constant for all reject calls.
Remove an unused import.