Skip to content

fix(camera)!: don't lazy load Camera plugin to prevent bug in Safari - #1978

Merged
jcesarmobile merged 2 commits into
ionic-team:mainfrom
stephan-fischer:main
Jan 10, 2024
Merged

fix(camera)!: don't lazy load Camera plugin to prevent bug in Safari#1978
jcesarmobile merged 2 commits into
ionic-team:mainfrom
stephan-fischer:main

Conversation

@stephan-fischer

@stephan-fischer stephan-fischer commented Dec 30, 2023

Copy link
Copy Markdown
Contributor

Solution is, to early import the web package. Safari tracks time differences between click and code execution to open the input file picker.

closes #1314

@jcesarmobile jcesarmobile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you only import CameraWeb instead of * and remove the comment?

Take clipboard plugin as an example
#342

@jcesarmobile jcesarmobile changed the title bug(camera): pickImages() doesn't work first time on safari #1314 fix(camera)!: don't lazy load Camera plugin to prevent bug in Safari Jan 9, 2024
@stephan-fischer

Copy link
Copy Markdown
Contributor Author

Can you only import CameraWeb instead of * and remove the comment?

Take clipboard plugin as an example #342

Done 😊

@jcesarmobile
jcesarmobile merged commit c131f71 into ionic-team:main Jan 10, 2024
@luofan189

Copy link
Copy Markdown

Hi, thx a lot for fixing this bug on Safari. Quick question, will this merge back to 5.x release? currently, we are still using xcode 13 and ready to migrate to xcode 15 yet and capacitor 6 yet. thx a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Camera pickImages() doesn't work first time on safari

3 participants