Fix(camera): bug in SDK 33 where opening the gallery when taking a picture fails due to permissions#1331
Closed
modus-jose wants to merge 2 commits intoionic-team:mainfrom
Closed
Fix(camera): bug in SDK 33 where opening the gallery when taking a picture fails due to permissions#1331modus-jose wants to merge 2 commits intoionic-team:mainfrom
modus-jose wants to merge 2 commits intoionic-team:mainfrom
Conversation
modus-jose
changed the title
ItsChaceD
requested review from
IT-MikeS,
ItsChaceD,
jcesarmobile,
markemer and
theproducer
ItsChaceD
approved these changes
Mar 9, 2023
jcesarmobile
requested changes
Mar 9, 2023
Member
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
the alias should be a simpler string, maybe call it media?
The new alias should be added to the types so it can be requested independently
https://github.com/ionic-team/capacitor-plugins/blob/main/camera/src/definitions.ts#L5-L10
And also should be documented in the README
Member
|
Address @jcesarmobile's comments and conflicts and this should be gtg. |
Member
|
This was addressed by the linked PR from chace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the release of Android 13, SDK 33 the permission for accesing media files changed.
https://developer.android.com/about/versions/13/behavior-changes-13
When using the camera plugin
It gives the option to open the gallery which fails with a no permissions error in Android 13.
Even when adding permissions in an ionic app, this plugin still doesn't has the permission to read media files
Solution
Detect if the app is using the sdk 33, and grant/check the proper permissions