chore: do not publish camera to CocoaPods#2513
Conversation
jcesarmobile
left a comment
There was a problem hiding this comment.
I don't think this is needed since camera was removed from the workspace in the package.json, so since the ci publish runs lerna run publish:cocoapod, it won't be run for camera plugin.
If you want to prevent a manual publish, maybe you can remove the whole script rather than changing it to an echo
Don't think that's the case, looking at https://github.com/ionic-team/capacitor-plugins/blob/main/.github/workflows/publish-ios.yml, it does
Yeah, that works too, my idea was to pass silently instead of failing, but I suppose it's better to be an explicit failure, I'll make that change |
Following PR comments
Description
Remove the cocoa pods publish command for Camera Plugin.
Because CocoaPods Publish workflow is triggered per plugin directory, removing this command means that if someone tries to push Camera to Trunk from this Repo (needs to explicitly list camera in plugin list input to workflow), the GitHub action will fail.
After this one is approved / merged I will also open a PR for 7.x, for filesystem and geolocation.
Change Type
Rationale / Problems Fixed
Capacitor camera is now housed in https://github.com/ionic-team/capacitor-camera, and
main/8.xin this repo is meant to serve only for historical purposes.To avoid GitHub Workflow failures and unforeseen issues, we should not try to push camera plugin 8.x to Trunk from this repo.
Notes / Comments
In terms of avoiding GitHub Workflow failures in Android, refer to #2512