Conversation
Co-authored-by: Dan Imhoff <dwieeb@gmail.com>
Co-authored-by: Dan Imhoff <dwieeb@gmail.com>
Co-authored-by: Dan Imhoff <dwieeb@gmail.com>
| } | ||
|
|
||
| async getInfo(): Promise<AppInfo> { | ||
| throw this.unimplemented('Not implemented on web.'); |
There was a problem hiding this comment.
I would suggest it will be a lot more useful (and developer-friendly) to return the information you can get from package.json, rather than throw an error.
There was a problem hiding this comment.
dwieeb already answered you on the other comment, the package.json is not accesible from the app/plugin, would need some CLI work first.
There was a problem hiding this comment.
Github is refusing to show me the other comment and his response, that's why I had to post it again.
I forgot this is a separate plugin now. Maybe Capacitor could make the app's package.json (or a subset of it) available to plugins.
There was a problem hiding this comment.
You have to click "Show resolved":
There was a problem hiding this comment.
Thanks, the github review UI is getting better, but is still somewhat confusing at times.
5 participants
removed openUrl and canOpenUrl functions, will be a separate plugin
add getInfo function to get information about the app (was part of Device plugin but got removed because makes more sense here)
depends on ionic-team/capacitor#3676
closes #72