Skip to content

Android camera orientation#359

Merged
mlynch merged 6 commits intoionic-team:masterfrom
peterpeterparker:android-camera-orientation
Mar 21, 2018
Merged

Android camera orientation#359
mlynch merged 6 commits intoionic-team:masterfrom
peterpeterparker:android-camera-orientation

Conversation

@peterpeterparker
Copy link
Copy Markdown
Contributor

Hi,

Here's a PR to fix the camera orientation related to the issue #307

Furthermore to the proposal of fix itself, I did a couple of other changes.

Summarized this PR contains:

  • Fix for the camera orientation using ExifInterface (only supported on Android API >= 24, that's why I tried to use it only if the Build version match this)
  • Refactoring of inner class/enums in separate class/enums
  • Added the missing close to InputStreams
  • Added a new logError method
  • Set the default quality to 90 instead of 100 (100 could generate big image and should be use when aware of the "risk")
  • Move ImageUtils to new package camera since it's only use by the camera

These are proposals, of course I would not mind if you reject it ;)

Best regards
David

@mlynch
Copy link
Copy Markdown
Contributor

mlynch commented Mar 21, 2018

Awesome! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants