Allow setting request body in file transfer download options#13
Open
Erdragh wants to merge 1 commit intoionic-team:mainfrom
Open
Allow setting request body in file transfer download options#13Erdragh wants to merge 1 commit intoionic-team:mainfrom
Erdragh wants to merge 1 commit intoionic-team:mainfrom
Conversation
Erdragh
force-pushed
the
feature/download-request-body
branch
from
2a7a66d to
a3dd651
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to pass a request body (as a
ByteArray) to the download process.The additional implementation of
equalsandhashCodewere suggested by IntelliJ/Android Studio because of theByteArray.Type of changes
Tests
I have tested it together with my PR to the capacitor file transfer plugin on a Samsung Galxy S22, where I download a blob from our backend which is identified via a protobuf request body.
Checklist