Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

test(generators): improve failure path tests #861

Merged
danbucholtz merged 1 commit into from
Apr 21, 2017
Merged

test(generators): improve failure path tests #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions src/generators/util.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ $TAB_CONTENT
const suppliedName = 'settings view';

it('should return a succesful promise', () => {
// set up spies
spyOn(helpers, helpers.readFileAsync.name).and.returnValue(Promise.resolve('file content'));
spyOn(fs, 'readdirSync').and.returnValue([
join(process.cwd(), 'path', 'to', 'nowhere'),
Expand All @@ -419,22 +420,18 @@ $TAB_CONTENT
spyOn(TypeScriptUtils, TypeScriptUtils.insertNamedImportIfNeeded.name).and.returnValue('file content');
spyOn(TypeScriptUtils, TypeScriptUtils.appendNgModuleDeclaration.name).and.returnValue('sliced string');

// what we want to test
const promise = util.tabsModuleManipulation([['/src/pages/cool-tab-one/cool-tab-one.module.ts']], { name: suppliedName, className: className, fileName: fileName }, [{ name: suppliedName, className: className, fileName: fileName }]);

// test
return promise.then(() => {
expect(helpers.readFileAsync).toHaveBeenCalled();
expect(helpers.writeFileAsync).toHaveBeenCalled();
});
});

it('should throw when files are not written succesfully', () => {
/*spyOn(helpers, helpers.writeFileAsync.name).and.throwError;

expect(util.tabsModuleManipulation([['/src/pages/cool-tab-one/cool-tab-one.module.ts']], { name: suppliedName, className: className, fileName: fileName }, [{ name: suppliedName, className: className, fileName: fileName }])).toThrow();
*/
// This test is not working correctly, it should look more like this below
/*
const knownErrorMsg = 'some known error';
const knownErrorMsg = `ENOENT: no such file or directory, open 'undefined/settings-view.module.ts'`;
spyOn(helpers, helpers.writeFileAsync.name).and.returnValue(Promise.reject(new Error(knownErrorMsg)));

const promise = util.tabsModuleManipulation([['/src/pages/cool-tab-one/cool-tab-one.module.ts']], { name: suppliedName, className: className, fileName: fileName }, [{ name: suppliedName, className: className, fileName: fileName }]);
Expand All @@ -443,7 +440,6 @@ $TAB_CONTENT
}).catch((err: Error) => {
expect(err.message).toEqual(knownErrorMsg);
});
*/
});

});
Expand Down Expand Up @@ -486,22 +482,15 @@ $TAB_CONTENT
});

it('should throw when files are not written succesfully', () => {
/*spyOn(helpers, helpers.writeFileAsync.name).and.throwError;

expect().toThrow();
*/
// This above test is likely not working correctly
// it should look more like this
/*
const knownErrorMsg = 'some error';
const knownErrorMsg = `ENOENT: no such file or directory, open 'src/pages/cool-tab-one/cool-tab-one.module.ts'`;
spyOn(helpers, helpers.writeFileAsync.name).and.returnValue(Promise.reject(new Error(knownErrorMsg)));

const promise = util.nonPageFileManipulation(context, 'coolStuff', join('src', 'pages', 'cool-tab-one', 'cool-tab-one.module.ts'), 'pipe');
return promise.then(() => {
throw new Error('should never happen');
}).catch((err: Error) => {
expect(err.message).toEqual(knownErrorMsg);
});
*/
});
});
});