Skip to content

fix(first-app-v4): about page refs - fixes #242 #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2019
Merged

fix(first-app-v4): about page refs - fixes #242 #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6cb3be
Fix first-app-v4/intro.md - fix about page ref
rtpHarry Dec 28, 2018
52d2f5c
Replace about page reference with gallery page
rtpHarry Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/content/developer-resources/guides/first-app-v4/intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ ionic serve
And voilà! Your Ionic app is now running in a web browser. Most of your app can be built right in the browser, greatly increasing development speed.

## Photo Gallery!!!
There are three tabs. Click on the Tab2 tab. It’s a blank canvas, aka the perfect spot to add camera functionality. Let’s begin to transform the About page into a Photo Gallery. Ionic features LiveReload, so when you make changes and save them, the app is updated immediately!
There are three tabs. Click on the Tab2 tab. It’s a blank canvas, aka the perfect spot to add camera functionality. Let’s begin to transform this page into a Photo Gallery. Ionic features LiveReload, so when you make changes and save them, the app is updated immediately!

![Before and after going through this tutorial](/docs/assets/img/guides/first-app-v3/email-photogallery.gif)

Expand All @@ -102,7 +102,7 @@ Open the photo-gallery app folder in your favorite code editor of choice, then n
Next, open `src/app/tabs/tabs.page.html`. Change the label to “Gallery” and the icon name to “images”:

```html
<ion-tab-button tab="about">
<ion-tab-button tab="tab2">
<ion-icon name="images"></ion-icon>
<ion-label>Gallery</ion-label>
</ion-tab-button>
Expand All @@ -112,8 +112,8 @@ Now, back up your changes to Ionic Appflow:

```shell
$ git add .
$ git commit -m "converting about page to photo gallery"
$ git commit -m "converting tab2 page to photo gallery"
$ git push ionic master
```

That’s just the start of all the cool things we can do with Ionic. Up next, we’ll deploy the app to iOS and Android, then continue building the photo gallery.
That’s just the start of all the cool things we can do with Ionic. Up next, we’ll deploy the app to iOS and Android, then continue building the photo gallery.
4 changes: 2 additions & 2 deletions src/content/developer-resources/guides/first-app-v4/ios-android-camera.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ providers: [

It can now be used on any of our App pages.

## Add the Camera to the About page
## Add the Camera to the Gallery page

Our camera button doesn’t do anything yet. Over in `tab2.page.html`, add a click handler to the button:

Expand Down Expand Up @@ -169,4 +169,4 @@ git commit -m "added camera functionality"
git push ionic master
```

Next, we’ll look at how to transform the app into a photo gallery, as well as how to save the photos to your device!
Next, we’ll look at how to transform the app into a photo gallery, as well as how to save the photos to your device!