Skip to content

Conversation

@rdlabo
Copy link
Collaborator

@rdlabo rdlabo commented Oct 7, 2025

Deprecating the old build method in https://github.com/ionic-team/ionic-docs/blob/main/scripts/api-ja.mjs and will instead execute generateMarkdownForVersion according to the i18n locate.

We can use this to check whether the build is running successfully.

  • build/api/accordion/index.html not include this word: trueの場合、アコーディオンは対話することができません。
  • build/ja/api/accordion/index.html include this word: trueの場合、アコーディオンは対話することができません。

This confirms that https://unpkg.com/@ionic/docs@${npmTag}/core.json and https://raw.githubusercontent.com/ionic-jp/ionic-docs/main/scripts/data/translated-api.json are switching correctly.

@rdlabo rdlabo requested a review from a team as a code owner October 7, 2025 23:07
@rdlabo rdlabo requested a review from thetaPC October 7, 2025 23:07
@vercel
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-docs Ready Ready Preview Comment Nov 21, 2025 7:26am

@rdlabo rdlabo requested a review from brandyscarney October 7, 2025 23:09
@rdlabo rdlabo force-pushed the fix/translate_script branch from 627c8b6 to 3beb30d Compare October 7, 2025 23:15
@rdlabo rdlabo enabled auto-merge (squash) October 18, 2025 00:11
@rdlabo rdlabo marked this pull request as draft November 12, 2025 23:54
auto-merge was automatically disabled November 12, 2025 23:54

Pull request was converted to draft

@rdlabo
Copy link
Collaborator Author

rdlabo commented Nov 12, 2025

Note: not use i18n function, use npm run build only.

@rdlabo rdlabo marked this pull request as ready for review November 21, 2025 07:15
@rdlabo rdlabo enabled auto-merge (squash) November 21, 2025 10:12
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@rdlabo rdlabo merged commit 6423551 into main Nov 24, 2025
4 checks passed
@rdlabo rdlabo deleted the fix/translate_script branch November 24, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants