feat(checkbox): add small size #29253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- here are the changes to have the checkbox small;
JoaoFerreira-FrontEnd
requested review from
a team,
averyjohnston,
liamdebeasi,
sean-perkins and
thetaPC
as code owners
github-actions
bot
added
package: core
sean-perkins
suggested changes
Apr 2, 2024
Contributor
sean-perkins
left a comment
sean-perkins
left a comment
There was a problem hiding this comment.
Small requested changes.
Do you need any assistance for generating screenshots locally for this PR?
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
sean-perkins
changed the title
sean-perkins
approved these changes
Apr 2, 2024
Contributor
sean-perkins
left a comment
sean-perkins
left a comment
There was a problem hiding this comment.
Changes look good to me, great work. Just waiting on CI to pass. I restarted the job since the flaky alert dynamic scaling test is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves N/A
What is the current behavior?
What is the new behavior?
-- The small size of the checkbox is 16px.
Does this introduce a breaking change?