bug: No/wrong modal closing animation from nested page

[davidruisinger]

Type: bug

Ionic Version: 2.x

Platform: ios 9 browser

See this example:
http://plnkr.co/edit/kBxwyE?p=preview

What I've built:

1. Modal opens with Page 1
2. From modal's page 1 you navigate to modal's page 2
3. From That second modal page I try to close the modal again (Either with popToRoot() or ViewController.dismiss() )
   => In both cases there is NO animation (Chrome) or the wrong animation (Safari).

Expected:
The modal should close as it always does with the "modal-slide-out" animation.

[davidruisinger]

I tried to configure the leavingOpts on the modal with:

let modal = this.nav.getByIndex(1);
console.log(modal);
modal.setLeavingOpts({
  animation: "modal-slide-out",
  direction: "back",
  ev: undefined,
  keyboardClose: false
});

modal.dismiss();

But this throws an error:

browser_adapter.js:77 TypeError: Cannot read property 'getBoundingClientRect' of null
    at new ModalSlideOut (modal.js:237)

[davidruisinger]

I somehow solved this by creating a "wrapper" component with a new navigation stack:

...
  openModal() {
    let modal = Modal.create(ModalNavigation);
    // Promise that is resolved when Modal is dismissed
    this.nav.present(modal); 
  }
}

// Just a helper Wrapper component to create a new navigation stack for the modal
@Component({
  template: `<ion-nav [root]="root"></ion-nav>`
})
class ModalNavigation {
  root = ModalPage1;
}

and then I can just use this function in every modal page to close the modal:

closeModal() {
  // Get the Modal which is (hopefully) in the rootNav at index 1
  let modal = this.nav.rootNav.getByIndex(1);
  // Dismiss the Modal
  modal();
}

Example: http://run.plnkr.co/plunks/sb1PBa/

So if the ionic team thinks that this should be the intended way to do something like that, I'm okay with it and this issue can be closed.

[jgw96]

Hello! Would you mind testing this issue with the latest nightly please? To install Ionic 2 nightly you can simply run npm install ionic-angular@nightly thanks!

[davidruisinger]

@jgw96 Should I test my "workaround"/solution with the latest nightly or the attempts that I mentioned in my original post?

[jgw96]

Hello @flavordaaave ! If you could test with the latest nightly using this.viewController.dismiss() to dismiss the modal, as shown in the docs here, that would be great (: