refactor(nav): remove nav-push, nav-pop nav-root #19240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove close button * update tests * update tests * add build
brandyscarney
force-pushed
the
remove-nav-push-pop-root
branch
from
5784850 to
4570497
Compare
* Remove close button * update tests * update tests * add build
brandyscarney
added a commit
that referenced
this pull request
Oct 7, 2019
BREAKING CHANGES Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
brandyscarney
added a commit
that referenced
this pull request
Oct 8, 2019
BREAKING CHANGES Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
brandyscarney
added a commit
that referenced
this pull request
Oct 9, 2019
BREAKING CHANGES Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
brandyscarney
added a commit
that referenced
this pull request
Oct 10, 2019
BREAKING CHANGES Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
elylucas
pushed a commit
that referenced
this pull request
Oct 30, 2019
BREAKING CHANGES Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ READY TO MERGE - deprecations in v4 ✅
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #18933
What is the new behavior?
ion-nav-pop,ion-nav-pushandion-nav-set-rootin favor of usingion-nav-linkwithrouter-directionDoes this introduce a breaking change?
Other information