Skip to content

fix(grid): apply no-padding to children columns #19592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 10, 2019
Merged

fix(grid): apply no-padding to children columns #19592

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6f55efb
refactor(toast): remove showCloseButton and closeButtonText (#18957)
liamdebeasi Aug 20, 2019
9b2766f
refactor(): deprecate web component controllers (#19109)
manucorporat Aug 27, 2019
d00fe3e
refactor(nav): remove nav-push, nav-pop nav-root (#19240)
brandyscarney Sep 27, 2019
8944e42
refactor(scss): remove scss (#19292)
brandyscarney Sep 27, 2019
1401bb6
refactor(themes): update to new ionic colors (#19279)
brandyscarney Sep 27, 2019
afb8bf0
refactor(css): remove CSS util attributes (#18956)
brandyscarney Sep 27, 2019
efc33bb
refactor(skeleton-text): remove width property (#18936)
brandyscarney Sep 30, 2019
f4bc70b
refactor(anchor): remove anchor in favor of router-link (#18935)
brandyscarney Sep 30, 2019
25a531b
refactor(searchbar): remove boolean values from showCancelButton (#18…
brandyscarney Sep 30, 2019
83d3782
refactor(): remove no-border references, add ion-no-border class (#18…
liamdebeasi Oct 1, 2019
964730d
refactor(): remove [main] from split-pane (#19511)
liamdebeasi Oct 2, 2019
b942726
refactor(): remove deprecated swipeEnable (#19526)
liamdebeasi Oct 2, 2019
ca3c2ec
feat(menu): default to overlay for ios menu (#19063)
adamdbradley Oct 8, 2019
d42b83c
feat(components): cascade mode from parent to child components (#19369)
brandyscarney Oct 8, 2019
4dcabf4
feat(overlays): add global backdrop opacity variable for animations (…
brandyscarney Oct 8, 2019
7b95fa2
fix(css): update responsive display media queries (#18601)
oori Oct 8, 2019
eee23e0
fix(grid): set the globals for column based on no padding on grid
brandyscarney Oct 8, 2019
d8a12bf
Merge branch 'master' into fix-grid-no-padding
brandyscarney Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions core/src/components/grid/grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@
// --------------------------------------------------

// Remove the padding from grid and all immediate children columns
:host([no-padding]) {
@include padding(0);
}

:host([no-padding]) ::slotted(ion-col) {
@include padding(0);
:host(.ion-no-padding) {
--ion-grid-column-padding: 0;
--ion-grid-column-padding-xs: 0;
--ion-grid-column-padding-sm: 0;
--ion-grid-column-padding-md: 0;
--ion-grid-column-padding-lg: 0;
--ion-grid-column-padding-xl: 0;
}