Skip to content

feat(gesture): add support for blurring active inputs on gesture start #20638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2020
Merged

feat(gesture): add support for blurring active inputs on gesture start #20638

merged 3 commits into from
Apr 27, 2020

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 27, 2020 •
edited
Loading

blocks ionic-team/ionic-docs#1331

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20588

What is the new behavior?

  • Menu gets and blurs any active element when swiping to open menu

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 27, 2020
@liamdebeasi
Copy link
Contributor Author

This may end up becoming a feature for the gesture util, but I'm not quite sure yet. Going to close for now until I can collect more feedback.

@liamdebeasi liamdebeasi reopened this Feb 27, 2020
@liamdebeasi liamdebeasi changed the title fix(menu): blur inputs when swiping to open menu feat(gesture): add support for blurring active inputs on gesture start Feb 27, 2020
@liamdebeasi liamdebeasi marked this pull request as ready for review February 27, 2020 20:12
haevensk
haevensk reviewed Feb 28, 2020
View reviewed changes
This was referenced Mar 26, 2020
Closed
Merged
liamdebeasi
liamdebeasi commented Mar 26, 2020
View reviewed changes
@liamdebeasi liamdebeasi merged commit 32ecdd6 into master Apr 27, 2020
@liamdebeasi liamdebeasi mentioned this pull request Apr 27, 2020
Closed
@liamdebeasi liamdebeasi deleted the menu-blur branch April 27, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

+1 more reviewer

@haevensk haevensk haevensk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liamdebeasi @brandyscarney @haevensk