Skip to content

fix(content): Interrupt Momentum on Scroll #20655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(content): Interrupt Momentum on Scroll #20655

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
325d05f
Merge pull request #1 from ionic-team/master
EinfachHans Feb 29, 2020
63b20ec
fix(content): interrupt Momentum on Scroll
EinfachHans Feb 29, 2020
f45afce
Merge remote-tracking branch 'upstream/master' into issue-20423
EinfachHans Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/src/components/content/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@ export class Content implements ComponentInterface {
return;
}

// Stop possible Momentum Scroll
el.style.setProperty('--overflow', 'hidden');

let resolve!: () => void;
let startTime = 0;
const promise = new Promise<void>(r => resolve = r);
Expand Down Expand Up @@ -265,6 +268,11 @@ export class Content implements ComponentInterface {

} else {
resolve();

// Reset the Overflow Property to Auto
setTimeout(() => {
el.style.setProperty('--overflow', 'auto');
}, 10);
}
};
// chill out for a frame first
Expand Down