Skip to content

fix(ios): add haptic drag gesture for action sheet and alert components #21060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 26, 2020
Merged

fix(ios): add haptic drag gesture for action sheet and alert components #21060

merged 7 commits into from
May 26, 2020

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 16, 2020 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: fixes #21052

What is the new behavior?

  • Added a custom gesture that a) adds ion-activated to action sheet/alert buttons and b) triggers a "selectionChanged" haptic feedback when pointer is over a button

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Apr 16, 2020
@liamdebeasi liamdebeasi mentioned this pull request Apr 20, 2020
Closed
@liamdebeasi liamdebeasi marked this pull request as ready for review April 23, 2020 20:08
@brandyscarney brandyscarney self-requested a review April 27, 2020 15:47
@liamdebeasi liamdebeasi changed the title feat(ios): add haptic drag gesture for action sheet and alert components fix(ios): add haptic drag gesture for action sheet and alert components May 1, 2020
@liamdebeasi liamdebeasi merged commit 33be1f0 into master May 26, 2020
@liamdebeasi liamdebeasi deleted the action-sheet-hover branch May 26, 2020 15:33
@rdlabo rdlabo mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney Awaiting requested review from brandyscarney

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

More Native-Feeling swiping between Items (iOS)

2 participants

@liamdebeasi