Skip to content

Conversation

@willmartian
Copy link
Contributor

@willmartian willmartian commented Jul 8, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23520

What is the new behavior?

  • ion-segment now responds properly to keyboard navigation.

Does this introduce a breaking change?

  • Yes
  • No

@github-actions github-actions bot added the package: core @ionic/core package label Jul 8, 2021
@willmartian willmartian requested a review from liamdebeasi July 12, 2021 20:48
@willmartian willmartian marked this pull request as ready for review July 13, 2021 13:17
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! A few small comments, but overall this is a really solid PR.

@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package labels Jul 20, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise this looks good to go. One lingering question and a couple docs changes.

@liamdebeasi liamdebeasi changed the title fix(segment): add keyboard navigation feat(segment): add keyboard navigation, add selectOnFocus property to control selection follow focus behavior Jul 20, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Once the builds pass this is good to merge. Be sure to mark this as a feature since we are adding an API.

I updated the PR title, but you may have to set the commit message yourself when merging.

@willmartian willmartian merged commit b6c53e5 into next Jul 20, 2021
@willmartian willmartian deleted the fix/23520 branch July 20, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants