Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Aug 2, 2023

Issue number: resolves #27910


What is the current behavior?

There is an edge case in our ion-item-sliding code where options can be added after the querySelectorAll has been run in updateOptions but before watchForOptions has been called which causes us to miss the newly created options. These options can never be shown as a result.

What is the new behavior?

  • watchForOptions is called before the initial updateOptions call so that we can re-run updateOptions in the event that options are added while that first call is running.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 7.2.2-dev.11690983626.19a2a8cb

@github-actions github-actions bot added the package: core @ionic/core package label Aug 2, 2023
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@liamdebeasi liamdebeasi marked this pull request as ready for review August 2, 2023 13:47
@liamdebeasi liamdebeasi added this pull request to the merge queue Aug 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit a0b3ef0 Aug 2, 2023
@liamdebeasi liamdebeasi deleted the FW-4868 branch August 2, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-item-options added async are not shown

3 participants